Spurious high core mach fix#248
Merged
reilleya merged 1 commit intoreilleya:stagingfrom Oct 9, 2025
Merged
Conversation
akarev0
reviewed
Oct 7, 2025
… at beginning or end of burn
Contributor
|
@cfanderson999 thanks for implementing constant, could you please also attach one more screenshot - "after". How the graph will look like after your fix, thanks and sorry for me being annoying |
reilleya
approved these changes
Oct 9, 2025
Owner
reilleya
left a comment
reilleya
left a comment
There was a problem hiding this comment.
👍 Thanks for getting to the bottom of this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for spurious high core Machs caused by chamber pressure dropping at the beginning or end of a burn. Just made it cutoff when chamber pressure is below 1 atm which seems to have fixed the problem.
Example attached: