test(web): add tests for layers and styles#2157
Open
waqaszulfiqar wants to merge 5 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds new Playwright E2E coverage around (1) managing multiple layer styles in the editor and (2) adding layers via the “Data Source Manager” from external resources, along with new page objects to support these flows.
Changes:
- Added a serial E2E spec that creates a project/layer, adds multiple preset styles, switches between styles, renames/deletes a style, and verifies persistence.
- Added a serial E2E spec that exercises Data Source Manager tabs and adds GeoJSON / 3D Tiles layers (URL + inline value).
- Introduced new page objects for the Layer Style panel and Data Source Manager modal.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| e2e/tests/multipleStyles.spec.ts | New E2E coverage for adding/switching/renaming/deleting multiple layer styles. |
| e2e/tests/externalLayers.spec.ts | New E2E coverage for adding layers via Data Source Manager (GeoJSON / 3D Tiles) and basic tab verification. |
| e2e/pages/layerStylePanelPage.ts | New page object for style panel interactions (add/select/rename/delete). |
| e2e/pages/dataSourceManagerPage.ts | New page object for Data Source Manager modal interactions (tabs + GeoJSON/3D Tiles flows). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What I've done
What I haven't done
How I tested
Which point I want you to review particularly
Memo
Checklist