[v26.1.x] cluster/rm_stm: preserve open transaction producers in local snapshots#30019
Open
vbotbuildovich wants to merge 2 commits intoredpanda-data:v26.1.xfrom
Open
[v26.1.x] cluster/rm_stm: preserve open transaction producers in local snapshots#30019vbotbuildovich wants to merge 2 commits intoredpanda-data:v26.1.xfrom
vbotbuildovich wants to merge 2 commits intoredpanda-data:v26.1.xfrom
Conversation
do_take_local_snapshot filters producers by finished_requests, which
drops transactional producers that have begun (fence batch applied) but
not yet replicated data batches. On restart, the snapshot is loaded and
log replay starts from the snapshot offset skipping the fence batch.
Data batches replayed without the fence synthesize transaction state
with tx_seq{-1} and timeout=nullopt. This makes the transaction
impossible to commit (tx_seq mismatch), abort (tx_seq seen as from the
future), or auto-expire (timeout=max), permanently stalling LSO on the
partition.
Include producers with in-progress transactions in local snapshots
regardless of finished_requests so their tx_seq, timeout, and
coordinator partition survive the snapshot roundtrip.
(cherry picked from commit a697aa8)
Collaborator
Author
Retry command for Build#82568please wait until all jobs are finished before running the slash command |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30003