feat(orchestrator): migrate from Material UI v4 to MUI v5#3195
Open
lokanandaprabhu wants to merge 5 commits into
Open
feat(orchestrator): migrate from Material UI v4 to MUI v5#3195lokanandaprabhu wants to merge 5 commits into
lokanandaprabhu wants to merge 5 commits into
Conversation
Replace @material-ui imports with @mui across the orchestrator plugin and app shells, add StylesProvider with orchestrator JSS seed, shared ESLint ban on v4 imports, and fix sidebar logo spacing plus workflow table action icon sizing in NFS and legacy apps. Co-authored-by: Cursor <[email protected]>
lokanandaprabhu
requested review from
a team,
christoph-jerolimov,
karthikjeeyar and
lholmquist
as code owners
Unexpected ChangesetsThe following changeset(s) reference packages that have not been changed in this PR:
Note that only changes that affect the published package require changesets, for example changes to tests and storybook stories do not require changesets. Changed Packages
|
Co-authored-by: Cursor <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3195 +/- ##
==========================================
- Coverage 60.97% 60.97% -0.01%
==========================================
Files 2097 2095 -2
Lines 65147 65135 -12
Branches 17022 17022
==========================================
- Hits 39723 39713 -10
+ Misses 24844 24842 -2
Partials 580 580
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Replace inline styles with Box and sx on sidebar logo wrappers and SVG logos in NFS app, legacy app, and plugin dev shell per review feedback. Co-authored-by: Cursor <[email protected]>
Centralize frontend ESLint rules in eslint.frontend-shared.cjs and wire packages via relative require with documented no-relative-monorepo-imports exceptions. Remove plugin package export and form-package devDependencies. Co-authored-by: Cursor <[email protected]>
Import LogoFull and LogoIcon from @red-hat-developer-hub/backstage-plugin-theme (requires ^0.14.0) and remove local Backstage SVG copies in app shells. Co-authored-by: Cursor <[email protected]>
|
debsmita1
reviewed
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
Fixes: https://redhat.atlassian.net/browse/RHIDP-13834
Migrates the orchestrator workspace from Material UI v4 (
@material-ui/*) to MUI v5 (@mui/*).@material-uiimports in the orchestrator frontend plugin with@mui/material,@mui/icons-material, and@mui/styleswhere neededStylesProviderandcreateGenerateClassName({ seed: 'orchestrator' })to avoid JSS class-name collisions with the host appeslint.frontend-shared.cjs) to block reintroduction of v4 imports across the plugin, form packages, and NFS apppackages/app) and legacy (packages/app-legacy) app shells using inline styles (JSSmakeStylesin app shells was not applying without a theme provider)----NFS------
Screen.Recording.2026-05-21.at.12.07.41.PM.mov
----Legacy app -----
Screen.Recording.2026-05-21.at.12.03.52.PM.mov
✔️ Checklist