[rcore][sdl] Fix: Ordered monitor indexing for SDL3#5717
Open
somamizobuchi wants to merge 1 commit into
Open
Conversation
Formatting + fix missing ifdef
somamizobuchi
force-pushed
the
fix-sdl3-display-indexing
branch
from
7651d53 to
9400289
Compare
Contributor
Author
|
Hi @raysan5 I know this is not the priority for 6.0 but is there a timeline for review on this? Or anything I can do in the meantime? |
Owner
|
@somamizobuchi Just wait a bit more, |
raysan5
reviewed
Apr 28, 2026
| } | ||
|
|
||
| int numMonitors = 0; | ||
| SDL_DisplayID *displays = SDL_GetDisplays(&numMonitors); |
Owner
There was a problem hiding this comment.
I think an SDL_free(displays) is missing at the end
| { | ||
| TRACELOG(LOG_FATAL, "PLATFORM: Failed to find monitors"); | ||
| SDL_free(displays); | ||
| return -1; |
Owner
There was a problem hiding this comment.
I prefer to avoid ending the program if no monitor connected, maybe CORE.Window.ready = false?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SDL3 changed monitor indexing from ordered to logical IDs which breaks many functions that requires monitor index as input.
Solution
Similar to how gamepads are currently stored, keep an array of
displayIDs that are queried and set once duringPlatformInit()and indexed during function calls that require them. The event polling does not currently handle display add/remove events so this LUT is only valid if no monitors are added/removed.Tests
MacOS Tahoe 26.3
MacBook Air M3
SDL 3.4.2
Tested using
example/core/monitor_detectorwith two monitors