[core][DON'T MERGE] Triage nccl issue in test code#62282
Open
Sparks0219 wants to merge 1 commit intoray-project:masterfrom
Open
[core][DON'T MERGE] Triage nccl issue in test code#62282Sparks0219 wants to merge 1 commit intoray-project:masterfrom
Sparks0219 wants to merge 1 commit intoray-project:masterfrom
Conversation
Signed-off-by: Joshua Lee <joshlee@anyscale.com>
Sparks0219
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| name = "doc_code_direct_transport_nccl", | ||
| size = "small", | ||
| srcs = ["source/ray-core/doc_code/direct_transport_nccl.py"], | ||
| env = {"NCCL_DEBUG": "INFO"}, |
There was a problem hiding this comment.
Debug environment variable left in test configuration
Low Severity
The PR title explicitly says "DON'T MERGE" and is for triaging an NCCL issue. The env = {"NCCL_DEBUG": "INFO"} addition is a temporary debugging measure that produces verbose NCCL logging output. This is intentionally temporary diagnostic code that risks being accidentally merged into the main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Additional information