fix corrupted plain_unit_concat function#117
Open
Curly060 wants to merge 1 commit intorandom-archer:masterfrom
Open
fix corrupted plain_unit_concat function#117Curly060 wants to merge 1 commit intorandom-archer:masterfrom
Curly060 wants to merge 1 commit intorandom-archer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In environments where "systemctl cat" is not available the fallback function
plain_unit_concatis being used. That function corrupts the generated unit file because it does print "using synthetic concat for " to stdout which will then be the first line in the generated unit file,, see this code in mkinitcpio-install.sh:plain "using synthetic concat for $unit_name"This makes the syntax of the unit file invalid and thus breaks it. Since this is only a technical message with very low value, I have opted to remove it.