Open
Conversation
neheb
commented
Jul 6, 2025
rakshasa
reviewed
Jul 8, 2025
src/data/chunk_list.cc
Outdated
| throw internal_error("ChunkList::release(...) received an invalid handle."); | ||
|
|
||
| if (handle->object() < &*begin() || handle->object() >= &*end()) | ||
| if (handle->object() < &front() || handle->object() >= &back()) |
Owner
There was a problem hiding this comment.
End is off by one, should be >.
However I don't like this change as begin/end are more natural for iterators/position comparisons.
Contributor
Author
There was a problem hiding this comment.
I assume you mean &front/back and not simple front/back.
Owner
There was a problem hiding this comment.
No, I mean it is more natural to use begin/end when dealing with comparison of position.
A little cleaner. Signed-off-by: Rosen Penev <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A little cleaner.