Add Databricks support for service principals when running in Posit Connect with connectcreds#931
Draft
tnederlof wants to merge 1 commit intor-dbi:mainfrom
Draft
Add Databricks support for service principals when running in Posit Connect with connectcreds#931tnederlof wants to merge 1 commit intor-dbi:mainfrom
tnederlof wants to merge 1 commit intor-dbi:mainfrom
Conversation
This commit adds support for service principal credentials managed by Posit Connect alongside our existing support of viewer-based credentials. The meat of this is handled by a new function in the upcoming version of the `connectcreds` package (hence the Remote). Documentation updates are included. Co-authored-by: Aaroon Jacobs <[email protected]>
4103d9f to
288ec4c
Compare
Collaborator
|
I backed out the formatting-only changes from this and squashed + rebased the commits. I also set the |
Collaborator
|
Thank you!! Do yall want to see this change going in the odbc release to be submitted early next week? If so, on what timeline would you imagine connectcreds would be submitted to CRAN? |
simonpcouch
reviewed
Aug 21, 2025
| )) | ||
| } | ||
|
|
||
| if (is_installed("connectcreds") && connectcreds::has_service_account_token(workspace)) { |
Collaborator
There was a problem hiding this comment.
We could also just add a conditional on the connectcreds package version here, I think? And then merge without a Remotes on the dev version.
Collaborator
|
@simonpcouch We haven't been able to get it to work yet, so I'd say no, don't hold up the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CANNOT MERGE until
connectcredsreleaseAddresses: #930