Add stork registration quickstart#1531
Open
aureamunoz wants to merge 1 commit intoquarkusio:developmentfrom
Open
Add stork registration quickstart#1531aureamunoz wants to merge 1 commit intoquarkusio:developmentfrom
aureamunoz wants to merge 1 commit intoquarkusio:developmentfrom
Conversation
|
/cc @scrocquesel (amazon) |
fde2891 to
a849d45
Compare
ab72c2e to
eba0c7a
Compare
This comment has been minimized.
This comment has been minimized.
eba0c7a to
d8cf4cb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
f91e94c to
6ea2ce7
Compare
This comment has been minimized.
This comment has been minimized.
6ea2ce7 to
0999c36
Compare
This comment has been minimized.
This comment has been minimized.
cescoffier
requested changes
Mar 22, 2026
stork-automatic-consul-registration-quickstart/src/test/java/org/acme/RegistrationTest.java
Show resolved
Hide resolved
...c-custom-registration-quickstart/src/main/java/org/acme/services/CustomServiceRegistrar.java
Show resolved
Hide resolved
0999c36 to
bca0def
Compare
cescoffier
requested changes
Mar 23, 2026
stork-automatic-consul-registration-quickstart/src/test/java/org/acme/ConsulTestResource.java
Outdated
Show resolved
Hide resolved
...c-custom-registration-quickstart/src/main/java/org/acme/services/CustomServiceRegistrar.java
Show resolved
Hide resolved
...c-custom-registration-quickstart/src/main/java/org/acme/services/CustomServiceRegistrar.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
Member
Author
|
This can now be reviewed; I hope I’ve included all the necessary information @cescoffier |
This comment has been minimized.
This comment has been minimized.
Member
|
Hum the stork QuickStarts failing do not look good. |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
The stork quickstarts pass now. You can review @cescoffier , I've taken into account your comments. I will squash commits |
cescoffier
requested changes
Apr 2, 2026
...ammatic-custom-registration-quickstart/src/test/java/org/acme/ClientCallingResourceTest.java
Show resolved
Hide resolved
...rogrammatic-custom-registration-quickstart/src/main/java/org/acme/services/Registration.java
Outdated
Show resolved
Hide resolved
stork-automatic-consul-registration-quickstart/src/test/java/org/acme/RegistrationTest.java
Outdated
Show resolved
Hide resolved
stork-automatic-consul-registration-quickstart/src/test/java/org/acme/RegistrationTest.java
Show resolved
Hide resolved
stork-automatic-consul-registration-quickstart/src/test/java/org/acme/ConsulTestResource.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
f77f3f1 to
f7da814
Compare
Status for workflow
|
| Status | Name | Step | Failures | Logs | Raw logs |
|---|---|---|---|---|---|
| ❌ | Build - JDK 17 | Build with Maven |
Failures | Logs | Raw logs |
Full information is available in the Build summary check run.
Failures
⚙️ Build - JDK 17 #
- Failing: context-propagation-quickstart jta-quickstart
📦 context-propagation-quickstart
❌ org.acme.context.prices.PriceTest.test line 55 - More details - Source on GitHub
Details
org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in org.acme.context.prices.PriceTest was not fulfilled within 1 minutes 40 seconds.
at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1160)
at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1129)
at org.acme.context.prices.PriceTest.test(PriceTest.java:55)
Suppressed: io.quarkus.runtime.BlockingOperationNotAllowedException: @Transactional cannot start a JTA transaction within a reactive pipeline. If the annotated method is intended to be blocking, ensure it is executed on a worker thread, for example by annotating it with @Blocking. If the annotated method is intended to be reactive, consider using Hibernate Reactive, which supports @Transactio...
📦 jta-quickstart
❌ org.acme.quickstart.TransactionalResourceTest.testAsync2Endpoint line 61 - More details - Source on GitHub
Details
java.lang.AssertionError:
1 expectation failed.
Expected status code <200> but was <500>.
at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:344)
at io.restassured.internal.ResponseSpecificationImpl$HamcrestAssertionClosure.validate(ResponseSpecificationImpl.groovy:516)
at org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:344)
at io.restassured.internal.ResponseSpecificationImpl.validateResponseIfRequired(ResponseSpecificationImpl.groovy:714)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check list:
Your pull request:
developmentbranch999-SNAPSHOTversion of Quarkusmvn clean test)mvn clean package -Pnative)mvn clean verify -Pnative)README.mdfile (with build and run instructions)pom.xmlandREADME.mdRelated to quarkusio/quarkus#47997 and quarkusio/quarkus#53252