Artifacts need to be readable/executable as part of the root group in…#1317
Open
Jaland wants to merge 1 commit intoquarkusio:developmentfrom
Open
Artifacts need to be readable/executable as part of the root group in…#1317Jaland wants to merge 1 commit intoquarkusio:developmentfrom
Jaland wants to merge 1 commit intoquarkusio:developmentfrom
Conversation
… order to be used on an openshift container by default.
Member
|
Thanks for this PR. I think we will have to also apply that to the project generation in the core repository. @maxandersen do you know someone that would be able to be authoritative on these? I have seen some back and forth |
Member
|
Hmm. What version of openshift is it not working by default? We already test and use this on multiple openshift versions so would want to know more before changing it (again) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… order to be used on an openshift container by default.
Check list:
Your pull request:
developmentbranch999-SNAPSHOTversion of Quarkusmvn clean test)mvn clean package -Pnative)mvn clean verify -Pnative)README.mdfile (with build and run instructions)pom.xmlandREADME.mdCurrently, if you try to use this docker file on Openshift you get a permissions error when trying to run
run-java.sh. This is because the root group does not have access to execute that file. I don't think giving the root group access hurts the usage on other platforms but it will reduce the work for people trying to deploy onto Openshift.