FROMLIST: drm/display: add hw_params callback function to drm_connect…

[naala-qcom]

…or_hdmi_audio_ops

After reusing drm_hdmi_audio_* helpers and drm_bridge_connector integration in drm/msm/dp, we have dropped msm_dp_audio_hw_params and use msm_dp_audio_prepare instead. While userspace is still calling hw_params to do audio initialization, and we get the following errors:

q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: q6apm_lpass_dai_prepare() started
q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: q6apm_lpass_dai_prepare() started
q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: q6apm_lpass_dai_prepare() started
hdmi-audio-codec hdmi-audio-codec.0.auto: hdmi_codec_hw_params() started
q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: q6apm_lpass_dai_prepare() started
qcom-apm gprsvc:service:2:1: Error (1) Processing 0x01001002 cmd
qcom-apm gprsvc:service:2:1: DSP returned error[1001002] 1
q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: Failed to start APM port 104
q6apm-lpass-dais 3700000.remoteproc:glink-edge:gpr:service@1:bedais: ASoC error (-22): at snd_soc_dai_prepare() on DISPLAY_PORT_RX_0
MultiMedia2 Playback: ASoC error (-22): at dpcm_run_update_startup() on MultiMedia2 Playback

msm_dp_audio_prepare is not called because hdmi-codec driver only checks and runs hw_params before q6apm_lpass_dai_prepare(). This commit will add hw_params callback same as drm_connector_hdmi_audio_prepare, so that hdmi-codec driver can work with userspace alsa.

Tested with Radxa Dragon Q6A.

Link: https://lore.kernel.org/linux-arm-msm/[email protected]/
Fixes: 98a8920 ("drm/msm/dp: reuse generic HDMI codec implementation")

Tested-by: Krzysztof Kozlowski [email protected]

CRs-Fixed: 4493138

[qcomlnxci]

Test jobs on 209fd7a

• Job 68887 on lemans-evk
• Job 68881 on monaco-evk
• Job 68885 on qcs615-ride
• Job 68883 on qcs6490-rb3gen2
• Job 68886 on qcs8300-ride
• Job 68884 on qcs9100-ride-r3
• Job 68882 on sm8750-mtp

[qcomlnxci]

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	sm8750-mtp
0_qcom-next-ci-premerge-tests	◻️	◻️	◻️	◻️	◻️	◻️	❌ Fail
BT_FW_KMD_Service	◻️	❌ Fail	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
BT_ON_OFF	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	⚠️ skip
BT_SCAN	◻️	❌ Fail	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
CPU_affinity	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
DSP_AudioPD	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
Ethernet	◻️	✅ Pass	⚠️ skip	◻️	✅ Pass	⚠️ skip	⚠️ skip
Freq_Scaling	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
GIC	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
IPA	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
Interrupts	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
OpenCV	◻️	⚠️ skip	⚠️ skip	◻️	⚠️ skip	⚠️ skip	◻️
PCIe	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
Probe_Failure_Check	◻️	❌ Fail	✅ Pass	◻️	✅ Pass	❌ Fail	❌ Fail
RMNET	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
UFS_Validation	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
USBHost	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
WiFi_Firmware_Driver	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
WiFi_OnOff	◻️	⚠️ skip	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
cdsp_remoteproc	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
hotplug	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
irq	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
kaslr	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
pinctrl	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
qcom_hwrng	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
remoteproc	◻️	❌ Fail	✅ Pass	◻️	❌ Fail	✅ Pass	❌ Fail
rngtest	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
shmbridge	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
smmu	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
watchdog	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
wpss_remoteproc	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass

[sgaud-quic]

Boot failure on RB8 device :
https://lava-oss.qualcomm.com/scheduler/job/68887

[[0;32m  OK  [0m] Started [0;1;39mQRTR TFTP service[0m.
[   11.048559][  T324] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[   11.063720][  T327] NET: Registered PF_QIPCRTR protocol family
[   11.066415][  T239] qcom-ice 1d88000.crypto: Found QC Inline Crypto Engine (ICE) v3.2.0
[   11.066422][  T239] qcom-ice 1d88000.crypto: QC Hardware Key Manager (HWKM) version v1
[   11.066483][  T239] qcom-ice 1d88000.crypto: Not using HWKM. Supporting raw keys only.
[   11.066843][  T265] qcom-qmp-pcie-phy 1c14000.phy: supply vdda-qref not found, using dummy regulator

[qcomlnxci]

Test jobs on 209fd7a

• Job 69002 on lemans-evk
• Job 68881 on monaco-evk
• Job 68885 on qcs615-ride
• Job 68883 on qcs6490-rb3gen2
• Job 68886 on qcs8300-ride
• Job 68884 on qcs9100-ride-r3
• Job 68882 on sm8750-mtp

[qcomlnxci]

Test Matrix

Test Case	lemans-evk	monaco-evk	qcs615-ride	qcs6490-rb3gen2	qcs8300-ride	qcs9100-ride-r3	sm8750-mtp
0_qcom-next-ci-premerge-tests	◻️	◻️	◻️	◻️	◻️	◻️	❌ Fail
BT_FW_KMD_Service	◻️	❌ Fail	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
BT_ON_OFF	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	⚠️ skip
BT_SCAN	◻️	❌ Fail	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
CPUFreq_Validation	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
CPU_affinity	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
DSP_AudioPD	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
Ethernet	◻️	✅ Pass	⚠️ skip	◻️	✅ Pass	⚠️ skip	⚠️ skip
Freq_Scaling	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
GIC	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
IPA	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
Interrupts	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
OpenCV	◻️	⚠️ skip	⚠️ skip	◻️	⚠️ skip	⚠️ skip	◻️
PCIe	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
Probe_Failure_Check	◻️	❌ Fail	✅ Pass	◻️	✅ Pass	❌ Fail	❌ Fail
RMNET	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
UFS_Validation	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
USBHost	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
WiFi_Firmware_Driver	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
WiFi_OnOff	◻️	⚠️ skip	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
cdsp_remoteproc	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	❌ Fail
hotplug	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
irq	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
kaslr	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
pinctrl	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
qcom_hwrng	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
remoteproc	◻️	❌ Fail	✅ Pass	◻️	❌ Fail	✅ Pass	❌ Fail
rngtest	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
shmbridge	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
smmu	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass
watchdog	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	◻️
wpss_remoteproc	◻️	✅ Pass	✅ Pass	◻️	✅ Pass	✅ Pass	✅ Pass

[sgaud-quic]

Boot failure on RB8 device :
https://lava-oss.qualcomm.com/scheduler/job/68887

[[0;32m  OK  [0m] Started [0;1;39mQRTR TFTP service[0m.
[   11.048559][  T324] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[   11.063720][  T327] NET: Registered PF_QIPCRTR protocol family
[   11.066415][  T239] qcom-ice 1d88000.crypto: Found QC Inline Crypto Engine (ICE) v3.2.0
[   11.066422][  T239] qcom-ice 1d88000.crypto: QC Hardware Key Manager (HWKM) version v1
[   11.066483][  T239] qcom-ice 1d88000.crypto: Not using HWKM. Supporting raw keys only.
[   11.066843][  T265] qcom-qmp-pcie-phy 1c14000.phy: supply vdda-qref not found, using dummy regulator

[riteshk-quic]

Boot failure on RB8 device : https://lava-oss.qualcomm.com/scheduler/job/68887

[[0;32m  OK  [0m] Started [0;1;39mQRTR TFTP service[0m.
[   11.048559][  T324] cfg80211: Loading compiled-in X.509 certificates for regulatory database
[   11.063720][  T327] NET: Registered PF_QIPCRTR protocol family
[   11.066415][  T239] qcom-ice 1d88000.crypto: Found QC Inline Crypto Engine (ICE) v3.2.0
[   11.066422][  T239] qcom-ice 1d88000.crypto: QC Hardware Key Manager (HWKM) version v1
[   11.066483][  T239] qcom-ice 1d88000.crypto: Not using HWKM. Supporting raw keys only.
[   11.066843][  T265] qcom-qmp-pcie-phy 1c14000.phy: supply vdda-qref not found, using dummy regulator

The change is tested on RB8 device. Device booting fine locally.

Also in the logs of https://lava-oss.qualcomm.com/scheduler/job/68887, I don't see boot failure. It looks to be some automation timeout. Are other PR passing for RB8? Can we rerun again?