Render TorchAgent ClickHouse queries with real newlines#8064
Open
wdvr wants to merge 1 commit into
Open
Conversation
Previously ClickHouse query inputs were JSON.stringify'd, so newlines showed up as literal \n in the UI. Render the query field as raw text in the <pre> block and stringify only the remaining input fields.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TorchAgentPage/ToolUse.tsx, the tool input was rendered viaJSON.stringify(toolInput, null, 2), so multi-line ClickHouse queries showed up with literal\ncharacters instead of being formatted.toolInput.queryis a string, render it as raw text inside the existing<pre>(ToolInput) so newlines render. Remaining input fields (e.g.inline_result_limit_bytes) are still shown as pretty-printed JSON below.Test plan
queryfield) still render their input as JSON.