Rename CMake target executorch to executorch_prim_ops#19624
Draft
kirklandsign wants to merge 1 commit into
Draft
Rename CMake target executorch to executorch_prim_ops#19624kirklandsign wants to merge 1 commit into
executorch to executorch_prim_ops#19624kirklandsign wants to merge 1 commit into
Conversation
The `executorch` CMake target only contains 3 prim_ops files (et_copy_index.cpp, et_view.cpp, register_prim_ops.cpp) linked on top of executorch_core. The name `executorch` was misleading — it suggested the full runtime, but it's just prim_ops registration. Rename the target to `executorch_prim_ops` across all CMakeLists.txt and .cmake files. Update the definition-site comment to accurately describe what the target provides. Update the required_lib_list in executorch-config.cmake so find_library looks for the new name. The CMake package name (`find_package(executorch ...)`) and project namespace aliases (`executorch::backends` etc.) are unchanged.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19624
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: ❌ 11 New Failures, 1 Pending, 6 Unrelated Failures, 6 Unclassified FailuresAs of commit 4315f91 with merge base c4ec988 ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
executorchCMake target only contains 3 prim_ops files (et_copy_index.cpp, et_view.cpp, register_prim_ops.cpp) linked on top of executorch_core. The nameexecutorchwas misleading — it suggested the full runtime, but it's just prim_ops registration.Rename the target to
executorch_prim_opsacross all CMakeLists.txt and .cmake files. Update the definition-site comment to accurately describe what the target provides. Update the required_lib_list in executorch-config.cmake so find_library looks for the new name.The CMake package name (
find_package(executorch ...)) and project namespace aliases (executorch::backendsetc.) are unchanged.Test plan
CI
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani