drop upper bound in requires-python#901
Draft
radoering wants to merge 1 commit intopython-poetry:mainfrom
Draft
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR drops the upper bound from the project-wide File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
requires-python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal to drop the upper bound in
requires-python(cf https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#requires-python-upper-bounds).We still cannot lock without an upper bound because vendoring declares an upper bound.
We have two options to work around this:
python = "^3.10"intool.poetry.dependencies.<4.0.The first solution requires to update the lower bound in two places when dropping an old Python version. Thus, I decided for the second option but am willing to switch if there are strong opinions.
Summary by Sourcery
Relax Python version compatibility by removing the upper bound from the project’s required Python version while constraining the vendoring dev dependency to run only on Python versions below 4.0.
Enhancements: