Fix scipy file-object dataset pickling#11347
Open
puneetdixit200 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
topic-backends
io
topic-hypothesis
puneetdixit200
force-pushed
the
fix/11323-scipy-pickle
branch
from
199c7a7 to
087f464
Compare
headtr1ck
approved these changes
Jun 1, 2026
Collaborator
headtr1ck
left a comment
headtr1ck
left a comment
There was a problem hiding this comment.
No idea why a function works but a class not. Pickling is weird...
Anyway, LGTM
Collaborator
|
These workarounds are getting uglier and uglier with each iteration, haha. Now we even have globals. But I'm fine with this change. Maybe somebody else might want to take a look at this? |
headtr1ck
added
needs review
regression
and removed
topic-hypothesis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #11323.
This keeps the scipy file-object netCDF workaround class stable across opens by defining it at module scope again. That avoids replacing the class object that pickle resolves for an already-open dataset when another scipy file object is opened.
The regression test opens two scipy file-object-backed datasets and pickles the first while the second remains open.
Checklist
whats-new.rstapi.rstAI Disclosure
Tools: OpenAI GPT-5