Skip to content

Fix sidebar top being cut off on mobile browsers#2363

Open
hntk03 wants to merge 3 commits intopydata:mainfrom
hntk03:fix-issue-2358
Open

Fix sidebar top being cut off on mobile browsers#2363
hntk03 wants to merge 3 commits intopydata:mainfrom
hntk03:fix-issue-2358

Conversation

@hntk03
Copy link
Copy Markdown
Contributor

@hntk03 hntk03 commented Apr 28, 2026

This pull request fixes an issue where the top of the sidebar is cut off on mobile browsers.
Closes #2358

I was able to reproduce this issue on Safari on iPhone.

Why this happens

Using height: 100vh can cause layout issues on mobile browsers because it does not account for the address bar.

As a result, the top of the sidebar can be cut off.

Solution

Use dvh instead of vh, since it accounts for the dynamic viewport height.

@Yann-P
Copy link
Copy Markdown
Collaborator

Yann-P commented Apr 28, 2026

Thank you

I can confirm your fix works on firefox android

Is there a particular reason for the changes in comments and rgb syntax?

image

Copy link
Copy Markdown
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert the unrelated changes to comments / color defs. If there's compelling reason to change color defs, please do in a separate PR

@hntk03
Copy link
Copy Markdown
Contributor Author

hntk03 commented Apr 29, 2026

I didn’t intentionally modify the rgb syntax or related parts — those changes were automatically applied by pre-commit.ci (see the commit history).

If I revert those changes, will pre-commit.ci just re-apply them again?
Is there a recommended way to prevent pre-commit.ci from modifying files that are unrelated to this PR?

@Yann-P
Copy link
Copy Markdown
Collaborator

Yann-P commented Apr 29, 2026

Stylelint clashes with prettier. looking into it

@Yann-P
Copy link
Copy Markdown
Collaborator

Yann-P commented Apr 30, 2026

@hntk03 I fixed the precommit,
If you drop the ci commit and rebase your branch with main, it should not happen again

@hntk03
Copy link
Copy Markdown
Contributor Author

hntk03 commented May 1, 2026

@Yann-P
Thanks for fixing the pre-commit issue.
pre-commit.ci is now passing.
I have reverted the CI commit and rebased my branch.

@Yann-P
Copy link
Copy Markdown
Collaborator

Yann-P commented May 1, 2026

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in 0.17.x: top of navigation sidebar is cut on Android

3 participants