Fix sidebar top being cut off on mobile browsers#2363
Fix sidebar top being cut off on mobile browsers#2363hntk03 wants to merge 3 commits intopydata:mainfrom
Conversation
drammock
left a comment
There was a problem hiding this comment.
please revert the unrelated changes to comments / color defs. If there's compelling reason to change color defs, please do in a separate PR
|
I didn’t intentionally modify the rgb syntax or related parts — those changes were automatically applied by pre-commit.ci (see the commit history). If I revert those changes, will pre-commit.ci just re-apply them again? |
|
Stylelint clashes with prettier. looking into it |
|
@hntk03 I fixed the precommit, |
|
@Yann-P |
|
Thanks! |

This pull request fixes an issue where the top of the sidebar is cut off on mobile browsers.
Closes #2358
I was able to reproduce this issue on Safari on iPhone.
Why this happens
Using
height: 100vhcan cause layout issues on mobile browsers because it does not account for the address bar.As a result, the top of the sidebar can be cut off.
Solution
Use
dvhinstead ofvh, since it accounts for the dynamic viewport height.