Release v25.12.1#5359
Merged
Merged
Conversation
* fix: inputs dict bug w/ unprocessed child parameters, cache collision bugs * docs: changelog entry (cherry picked from commit 3517cff)
* minor composite esoh fixes * style: pre-commit fixes * try split composite eSOH solve * use split for initial conditions on failure * style: pre-commit fixes * fix v_low/high vs soc_0/100 * consisten min/max sto calculations * update changelog * style: pre-commit fixes * PR comments * fix direction in solve_split * Update src/pybamm/models/full_battery_models/lithium_ion/electrode_soh_composite.py Co-authored-by: Marc Berliner <34451391+MarcBerliner@users.noreply.github.com> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Marc Berliner <34451391+MarcBerliner@users.noreply.github.com> (cherry picked from commit 18461a1)
649e268 to
2641f1c
Compare
rtimms
approved these changes
Jan 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5359 +/- ##
==========================================
- Coverage 98.41% 98.39% -0.03%
==========================================
Files 326 326
Lines 28661 28661
==========================================
- Hits 28207 28201 -6
- Misses 454 460 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests