feat: add ServerUUID label to containers#279
Open
SeanLatimer wants to merge 1 commit intopterodactyl:developfrom
Open
feat: add ServerUUID label to containers#279SeanLatimer wants to merge 1 commit intopterodactyl:developfrom
SeanLatimer wants to merge 1 commit intopterodactyl:developfrom
Conversation
Add ServerUUID label to both server and installer containers for improved container identification and filtering using Docker's native label filtering capabilities. This enables querying containers by server ID independently of container names and supports multi-dimensional filtering by combining with existing Service and ContainerType labels.
DaneEveritt
reviewed
Dec 25, 2025
| Labels: map[string]string{ | ||
| "Service": "Pterodactyl", | ||
| "ContainerType": "server_installer", | ||
| "ServerUUID": ip.Server.ID(), |
Member
There was a problem hiding this comment.
Should we use something like PdtlId just to make it much more clear with the associated service labeling? ServerUUID is probably a little vague, all things considered.
I'd be open to also adding PdtlContainerTable as a label and deprecating ContainerType. Could also do Pterodactyl as the prefix, but that might get long and unweildly. End goal just being that these labels are tightly coupled to Pterodactyl itself and obvious at a glance without digging through this code to find what we set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ServerUUID label to both server and installer containers for improved container identification and filtering using Docker's native label filtering capabilities.
This enables querying containers by server ID independently of container names and supports multi-dimensional filtering by combining with existing Service and ContainerType labels.