Skip to content

feat(security): security best practices from StepSecurity #10500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stepsecurity-app wants to merge 1 commit into
base: master
Choose a base branch
from
+126 −0
Open

feat(security): security best practices from StepSecurity #10500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/api-bump-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ env:
PROWLER_VERSION: ${{ github.event.release.tag_name }}
BASE_BRANCH: master

permissions:
contents: read

jobs:
detect-release-type:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/api-code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ concurrency:
env:
API_WORKING_DIR: ./api

permissions:
contents: read

jobs:
api-code-quality:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/api-codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
api-analyze:
name: CodeQL Security Analysis
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/api-container-build-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ env:
PROWLERCLOUD_DOCKERHUB_REPOSITORY: prowlercloud
PROWLERCLOUD_DOCKERHUB_IMAGE: prowler-api

permissions:
contents: read

jobs:
setup:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/api-container-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ env:
API_WORKING_DIR: ./api
IMAGE_NAME: prowler-api

permissions:
contents: read

jobs:
api-dockerfile-lint:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/api-security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ concurrency:
env:
API_WORKING_DIR: ./api

permissions:
contents: read

jobs:
api-security-scans:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/api-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ env:
VALKEY_DB: 0
API_WORKING_DIR: ./api

permissions:
contents: read

jobs:
api-tests:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/backport.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ env:
BACKPORT_LABEL_PREFIX: backport-to-
BACKPORT_LABEL_IGNORE: was-backported

permissions:
contents: read

jobs:
backport:
if: github.event.pull_request.merged == true && !(contains(github.event.pull_request.labels.*.name, 'backport')) && !(contains(github.event.pull_request.labels.*.name, 'was-backported'))
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci-zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
zizmor:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/comment-label-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.issue.number }}
cancel-in-progress: false

permissions:
contents: read

jobs:
update-labels:
if: contains(github.event.issue.labels.*.name, 'status/awaiting-response')
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/conventional-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

permissions:
contents: read

jobs:
conventional-commit-check:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/create-backport-label.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ env:
BACKPORT_LABEL_PREFIX: backport-to-
BACKPORT_LABEL_COLOR: B60205

permissions:
contents: read

jobs:
create-label:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/docs-bump-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ env:
PROWLER_VERSION: ${{ github.event.release.tag_name }}
BASE_BRANCH: master

permissions:
contents: read

jobs:
detect-release-type:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/find-secrets.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
scan-secrets:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/helm-chart-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ concurrency:
env:
CHART_PATH: contrib/k8s/helm/prowler-app

permissions:
contents: read

jobs:
helm-lint:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/helm-chart-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ concurrency:
env:
CHART_PATH: contrib/k8s/helm/prowler-app

permissions:
contents: read

jobs:
release-helm-chart:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/labeler.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

permissions:
contents: read

jobs:
labeler:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/mcp-container-build-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ env:
PROWLERCLOUD_DOCKERHUB_REPOSITORY: prowlercloud
PROWLERCLOUD_DOCKERHUB_IMAGE: prowler-mcp

permissions:
contents: read

jobs:
setup:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/mcp-container-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ env:
MCP_WORKING_DIR: ./mcp_server
IMAGE_NAME: prowler-mcp

permissions:
contents: read

jobs:
mcp-dockerfile-lint:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/mcp-pypi-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ env:
PYTHON_VERSION: "3.12"
WORKING_DIRECTORY: ./mcp_server

permissions:
contents: read

jobs:
validate-release:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-check-changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

permissions:
contents: read

jobs:
check-changelog:
if: contains(github.event.pull_request.labels.*.name, 'no-changelog') == false
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-conflict-checker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

permissions:
contents: read

jobs:
check-conflicts:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/pr-merged.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: false

permissions:
contents: read

jobs:
trigger-cloud-pull-request:
if: |
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/prepare-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ concurrency:
env:
PROWLER_VERSION: ${{ inputs.prowler_version }}

permissions:
contents: read

jobs:
prepare-release:
if: github.event_name == 'workflow_dispatch' && github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-bump-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ env:
PROWLER_VERSION: ${{ github.event.release.tag_name }}
BASE_BRANCH: master

permissions:
contents: read

jobs:
detect-release-type:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-check-duplicate-test-names.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
check-duplicate-test-names:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
sdk-code-quality:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
sdk-analyze:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-container-build-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ env:
# AWS configuration (for ECR)
AWS_REGION: us-east-1

permissions:
contents: read

jobs:
setup:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-container-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ concurrency:
env:
IMAGE_NAME: prowler

permissions:
contents: read

jobs:
sdk-dockerfile-lint:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-pypi-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ env:
RELEASE_TAG: ${{ github.event.release.tag_name }}
PYTHON_VERSION: '3.12'

permissions:
contents: read

jobs:
validate-release:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-refresh-aws-services-regions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ env:
PYTHON_VERSION: '3.12'
AWS_REGION: 'us-east-1'

permissions:
contents: read

jobs:
refresh-aws-regions:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-refresh-oci-regions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ concurrency:
env:
PYTHON_VERSION: '3.12'

permissions:
contents: read

jobs:
refresh-oci-regions:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-security.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
sdk-security-scans:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/sdk-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
sdk-tests:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/test-impact-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ on:
description: "Whether there are UI E2E tests to run"
value: ${{ jobs.analyze.outputs.has-ui-e2e }}

permissions:
contents: read

jobs:
analyze:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ui-bump-version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ env:
PROWLER_VERSION: ${{ github.event.release.tag_name }}
BASE_BRANCH: master

permissions:
contents: read

jobs:
detect-release-type:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ui-codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

permissions:
contents: read

jobs:
ui-analyze:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ui-container-build-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ env:
# Build args
NEXT_PUBLIC_API_BASE_URL: http://prowler-api:8080/api/v1

permissions:
contents: read

jobs:
setup:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ui-container-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ env:
UI_WORKING_DIR: ./ui
IMAGE_NAME: prowler-ui

permissions:
contents: read

jobs:
ui-dockerfile-lint:
if: github.repository == 'prowler-cloud/prowler'
Expand Down
Loading
Loading