refactor(ui): remove "Clear all" button from filter pills strip#10481
Merged
Alan-TheGentleman merged 4 commits intomasterfrom Mar 30, 2026
Merged
refactor(ui): remove "Clear all" button from filter pills strip#10481Alan-TheGentleman merged 4 commits intomasterfrom
Alan-TheGentleman merged 4 commits intomasterfrom
Conversation
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Contributor
|
✅ All necessary |
Contributor
🔒 Container Security ScanImage: ✅ No Vulnerabilities DetectedThe container image passed all security checks. No known CVEs were found.📋 Resources:
|
alejandrobailo
requested changes
Mar 26, 2026
Contributor
alejandrobailo
left a comment
alejandrobailo
left a comment
There was a problem hiding this comment.
Nice cleanup! The "Clear all" removal and clearKeys dead-code deletion look good.
One thing to address before merging: the chips in FilterSummaryStrip are using Badge variant="outline", but they should use variant="tag" — that's the variant we use across the app for this kind of removable chip (multiselects, search chips, table tags, etc.). Since this PR is already touching this component, it'd be a good moment to fix it for consistency.
- <Badge variant="outline" className="flex items-center gap-1 pr-1">
+ <Badge variant="tag" className="flex items-center gap-1 pr-1">
alejandrobailo
previously approved these changes
Mar 27, 2026
9 tasks
The only clear-filters action is now the ClearFiltersButton in the top bar. This removes the redundant "Clear all" link next to the pills, along with the clearKeys helper in useFilterBatch and all related tests.
clearAll had no callers after the "Clear all" button removal. This removes the function, its interface type, and its 5 tests. Also rewrites clearAndApply JSDoc to stand alone.
Addresses PR review: Badge variant in FilterSummaryStrip changed from "outline" to "tag" for consistency with the rest of the app.
Alan-TheGentleman
force-pushed
the
refactor/ui-remove-pills-clear-all-button
branch
from
f2891dc to
8d7736c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Simplifies the filter UX by consolidating clear-filter actions into a single entry point — the Clear Filters button in the top bar. The redundant "Clear all" link next to the filter pills is removed.
Description
FilterSummaryStrip: removedonClearAllprop and the "Clear all"<button>elementFindingsFilters: removedhandleClearAllChips,PROVIDER_KEYSset, andclearKeysdestructuringuseFilterBatch: removedclearKeysfunction and its type fromUseFilterBatchReturnclearKeystests from hook test file, removedonClearAlltest block and all prop references from strip test fileNo new functionality — pure removal of dead code path.
Steps to review
FilterSummaryStriprenders chips with X buttons but no "Clear all" linkclearAndApplypnpm vitest run components/filters/filter-summary-strip.test.tsx hooks/use-filter-batch.test.ts— 36 tests passChecklist
Community Checklist
UI (if applicable)
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.