[WIP] hot module reload support for webpack5#66
[WIP] hot module reload support for webpack5#66ShoryuKyzan wants to merge 17 commits intoprivatenumber:developfrom
Conversation
* WIP - need help setting up build and test environment * for everything below, if not webpack 5, default actions are taken, no new functionality * process modules that contain placeholders and also if tagged as a hotmodule replacement * options set a hmrLocale that should be used for localizing HMR updates. * if hmr module, update the asset instead of delete/recreate asset. * if hmr module and nothing to update in the module, dont continue or emit anything (would cause infinite loop)
|
Thanks for the draft PR to let me know your intentions. I haven't actually tried with this HMR so glad you're working on it. Since linting & building all happens on GitHub Actions Linux, you can take a look at those environments for reference to debug. Linting warnings can be ignored but no errors allowed (this will be caught by CI or lint-hook hook). I'm not sure if I understand your testing questions. Have you tried running I think the highest value task right now is adding failing tests. We'll need tests to make sure this behavior is working anyway, but if there are failing test cases, it would make it easier for me or others to collaborate with you. |
|
I'll definitely check out the tests and github actions! |
|
Just fyi, currently working on releasing this in a github repo for now. Haven't had alot of chances to work on this. |
| with: | ||
| node-version-file: ".nvmrc" | ||
| registry-url: https://npm.pkg.github.com/ | ||
| scope: "@shoryukyzan" |
There was a problem hiding this comment.
TIL!
If you're just publishing to test, check out git-publish. It works like npm publish, but pushes to a GitHub branch.
|
I did manage to publish it! From looking at the tests you've defined, it seems like they don't cover this kind of thing. |
Update README.md
WIP
Summary
Localizes hot module replacement modules for webpack5, so that a localized application still functions with hot reload mode.
Help please
I made changes to the built NPM package, tested, and use it every day. Our setup is vue 3/vuetify 3/vue-loader. I need some guideance setting up natural test cases and building. The repo tests don't seem to reflect how to integrate this into a project?
I will slowly work on getting the below items correct, but assistance with setup would be a quicker way to get this published if you wish to have it.
npm run builddoesnt create any output that is like the content of node_modules. Just 2 minified filespnpmseems to be involved in the setup, and isn't quite working right on my system (windows + cygwin). I will look into getting this rightChanges