Add FontAwesome icons to section headings#487
Open
mcopik wants to merge 3 commits intoposquit0:masterfrom
Open
Add FontAwesome icons to section headings#487mcopik wants to merge 3 commits intoposquit0:masterfrom
mcopik wants to merge 3 commits intoposquit0:masterfrom
Conversation
OJFord
requested changes
Dec 29, 2025
| % SECTION TITLE | ||
| %------------------------------------------------------------------------------- | ||
| \cvsection{Education} | ||
| \cvsection[\faGraduationCap]{Education} |
Collaborator
There was a problem hiding this comment.
Please update the rendered example pdf if modifying here
Comment on lines
+632
to
+636
| \ifempty{#1}{ | ||
| \sectionstyle{#2} | ||
| }{ | ||
| \sectioniconstyle{#2}{#1} | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggest wrapping it all in \BeginAccSupp{ActualText={#2}} ... \EndAccSupp to avoid text conversion/ATS parsers seeing something like 'GRADUATION-CAP education'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Great work with the CV! I noticed that using Font Awesome icons in the CV comes with some troubles. It doesn't look terribly well because the coloring of section headings depends on the number of characters. Thus, adding an icon and additional spacings breaks the actual coloring.
This PR adds an optional argument to CV sections that allows to define an additional text or icon to the beginning of the section title, without affecting the display of the actual title: