Fix ReservedSql type to extend ISql instead of Sql#1161
Open
macrosak wants to merge 2 commits intoporsager:masterfrom
Open
Fix ReservedSql type to extend ISql instead of Sql#1161macrosak wants to merge 2 commits intoporsager:masterfrom
ReservedSql type to extend ISql instead of Sql#1161macrosak wants to merge 2 commits intoporsager:masterfrom
Conversation
`Omit` will not work, a common interface `ISql` for `Sql` and `TransactionSql` is introduced. microsoft/TypeScript#41362
ReservedSql incorrectly extends Sql, exposing methods like begin(), listen(), subscribe(), reserve(), end(), etc. that do not exist at runtime on reserved connections. Change it to extend ISql, matching the approach used for TransactionSql. Fixes porsager#713
macrosak
force-pushed
the
types/fix-reservedsql-type-with-isql
branch
from
70adfe6 to
da251e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReservedSqlincorrectly extendsSql, exposing methods likebegin(),listen(),subscribe(),reserve(),end(), etc. that do not exist at runtime on reserved connections. This changes it to extendISql, matching the approach used forTransactionSqlin #1144.Fixes #713
Depends on #1144