Open
Conversation
IlyaBat9
approved these changes
Oct 28, 2025
stsouko
reviewed
Jan 8, 2026
| from uuid import UUID | ||
|
|
||
| import cx_Oracle | ||
| import oracledb |
There was a problem hiding this comment.
import oracledb as cx_Oracle
is enough to keep changes minimal.
or better to support both
try:
import cx_Oracle
except ImportError:
import oracledb as cx_Oracle
There was a problem hiding this comment.
cx_Oracle imports also present in https://github.com/ponyorm/pony/blob/main/pony/orm/tests/fixtures.py#L269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys, I've just brought oracledb library support. It works the same way as the cx_Oracle.