Add a closure that runs just before the snapshot is taken.#1055
Open
maxchuquimia wants to merge 1 commit intopointfreeco:mainfrom
Open
Add a closure that runs just before the snapshot is taken.#1055maxchuquimia wants to merge 1 commit intopointfreeco:mainfrom
maxchuquimia wants to merge 1 commit intopointfreeco:mainfrom
Conversation
When snapshotting with SwiftUI, we wanted to wait for onAppear of the snapshotted view to be called before taking the snapshot as in some cases the final state of the view was not yet ready until then. We also wanted a way to wait until our own dispatch manager had reported no Tasks were still running (and therefore the final view state had been published). By adding a closure thats called between layout and the snapshot being taken, we can use our existing test infrastructure to wait for said expectations to ensure the snapshot properly reflects the state of a fully set up view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When snapshotting with SwiftUI, we wanted to wait for
onAppearof the snapshotted view to be called before taking the snapshot (as in some cases the final state of the view was not yet ready until then). We also wanted a way to wait until our own dispatch manager had reported noTasks were still running (and therefore the view models had published the final state of the SwiftUI view).By adding a closure that gets called between layout and the snapshot being taken, we can use our existing test infrastructure to wait for said expectations and therefore ensure the captured snapshot properly reflects the state of a fully set up view.