Add settings to enable visual or text editor for TinyMCE#6179
Draft
JoryHogeveen wants to merge 11 commits intomainfrom
Draft
Add settings to enable visual or text editor for TinyMCE#6179JoryHogeveen wants to merge 11 commits intomainfrom
JoryHogeveen wants to merge 11 commits intomainfrom
Conversation
JoryHogeveen
commented
Oct 19, 2021
Member
|
To initialize a quicktags-only textarea, you can call:
However, it does not appear well unless the textarea is wrapped with |
Member
|
We'll need to fix #6178 as a prerequisite for this |
sc0ttkclark
reviewed
Oct 22, 2021
| settings.toolbar4 = settings.toolbar4.replace( 'wp_add_media,', '' ).replace( ',wp_add_media', '' ).replace( 'wp_add_media', '' ); | ||
| } | ||
|
|
||
| if ( ! enableTinyMCE && ! enableQuicktags ) { |
Member
There was a problem hiding this comment.
We need to address other areas like in onSetup and the first useEffect perhaps?
Member
There was a problem hiding this comment.
Basically checking enableTinyMCE before calling other tinymce/editor specific functions elsewhere in this file
sc0ttkclark
reviewed
Oct 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will allow users to optionally disable the visual editor or the quicktags.
Related GitHub issue(s)
Fixes #6176
Changelog text for these changes
PR checklist