Enhance URL handling in file version commands to support relative URLs and improve decoding logic#4892
Merged
gautamdsheth merged 1 commit intopnp:devfrom May 2, 2025
Merged
Conversation
…s and improve decoding logic
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances URL handling in file version commands by ensuring relative URL processing and improving the URL decoding logic. Key changes include:
- Converting absolute URLs to relative ones using UrlUtility.MakeRelativeUrl.
- Modifying URL decoding logic to preserve the "+" character.
- Applying the same changes across RestoreFileVersion, RemoveFileVersion, and GetFileVersion commands.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Commands/Files/RestoreFileVersion.cs | Added absolute URL check and customized URL decoding logic |
| src/Commands/Files/RemoveFileVersion.cs | Added absolute URL check and customized URL decoding logic |
| src/Commands/Files/GetFileVersion.cs | Added absolute URL check and customized URL decoding logic |
Comments suppressed due to low confidence (3)
src/Commands/Files/RestoreFileVersion.cs:38
- Consider using StartsWith with a StringComparison parameter (e.g., StringComparison.OrdinalIgnoreCase) instead of converting both strings to lower case for clarity and efficiency.
if (!Url.ToLower().StartsWith(webUrl.ToLower()))
src/Commands/Files/RemoveFileVersion.cs:47
- Consider using StartsWith with a StringComparison parameter (e.g., StringComparison.OrdinalIgnoreCase) for a more robust case-insensitive comparison.
if (!Url.ToLower().StartsWith(webUrl.ToLower()))
src/Commands/Files/GetFileVersion.cs:34
- Consider using StartsWith with a StringComparison parameter (e.g., StringComparison.OrdinalIgnoreCase) to avoid potential issues with culture-specific casing.
if (!Url.ToLower().StartsWith(webUrl.ToLower()))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Related Issues?
Fixes #4723
What is in this Pull Request ?
Improved decoding logic for file versions