Skip to content

Updates root cli commands to zod. Closes #7289#7359

Open
waldekmastykarz wants to merge 2 commits into
pnp:mainfrom
waldekmastykarz:cli-root-zod
Open

Updates root cli commands to zod. Closes #7289#7359
waldekmastykarz wants to merge 2 commits into
pnp:mainfrom
waldekmastykarz:cli-root-zod

Conversation

@waldekmastykarz
Copy link
Copy Markdown
Member

Updates root cli commands to zod. Closes #7289

@MartinM85 MartinM85 self-assigned this May 31, 2026
Copy link
Copy Markdown
Contributor

@MartinM85 MartinM85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @waldekmastykarz, looks good to me. I would suggest adding tests to validate unknown options or no options, where appropriate. Like
passes validation with no options
fails validation with unknown options

@MartinM85 MartinM85 marked this pull request as draft June 1, 2026 07:26
Adds 'passes/fails validation with no options' and 'fails validation
with unknown options' tests for cli-consent, cli-doctor, and cli-issue
commands as suggested in PR review.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@waldekmastykarz waldekmastykarz marked this pull request as ready for review June 1, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate cli root commands to Zod

2 participants