Skip to content

feat: add install script#122

Open
zifeo wants to merge 1 commit intoplasmicapp:masterfrom
zifeo:install-script
Open

feat: add install script#122
zifeo wants to merge 1 commit intoplasmicapp:masterfrom
zifeo:install-script

Conversation

@zifeo
Copy link
Copy Markdown

@zifeo zifeo commented May 27, 2024

This is the logic that our team derived from the the multi installations step and might be useful for others. Happy to simply also other parts of the community build process and deployment if you are interested in those.

@vercel
Copy link
Copy Markdown

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
react-email-demo ⬜️ Ignored (Inspect) May 27, 2024 4:56pm

@rogerznts
Copy link
Copy Markdown

I got this error.

yarn build
yarn run v1.22.21
error Command "build" not found.

@zifeo
Copy link
Copy Markdown
Author

zifeo commented Aug 12, 2024

@rogerznts on which yarn build and exact commit (Plasmic) does that happen?

@kiyochinh
Copy link
Copy Markdown

Thank you, this nice script 🚀

@Salamit
Copy link
Copy Markdown

Salamit commented Jan 21, 2025

@kiyochinh does the script work for you?

continue
fi
echo "Building... $dir"
pushd platform/"$dir"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error at this line:

Building... platform/canvas-packages
./install.bash: line 42: pushd: platform/platform/canvas-packages: No such file or directory

Since $dir will already be prefixed with "platform/", I think this should be changed to:

    echo "Building... $dir"
    pushd "$dir"

pushd platform/"$dir"
if [ -f package.json ]; then
if [ "\$(jq -r '.scripts.build' package.json)" != "null" ]; then
NODE_ENV=production yarn build
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the following error at this line:

Building... platform/integration-tests
~/Development/plasmic/platform/integration-tests ~/Development/plasmic
yarn run v1.22.22
error Command "build" not found.

I think this should be changed to remove the backslash on line 44, ie:

    if [ -f package.json ]; then
        if [ "$(jq -r '.scripts.build' package.json)" != "null" ]; then
            NODE_ENV=production yarn build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants