Add dial-in/out and DTMF event handlers to all phone bots#200
Merged
Conversation
- Add full dial-in handlers (ready, connected, stopped, warning, error) to all dial-in and transfer bots - Add missing dial-out handlers (connected, stopped, warning) to daily-pstn-dial-out and daily-pstn-cold-transfer - Add on_dialout_warning to daily-pstn-warm-transfer - Add on_dtmf_event handler to all PSTN bots - Fix on_dialin_ready signature: use sip_endpoint param (not data) - Fix "Handling call from" to "Handling call to" for To field logging - Add caller/callee logging to daily-pstn-cold-transfer bot() - Improve log prefixes in warm-transfer for clarity (e.g., "Supervisor dial-out connected")
pipecat-ai/pipecat#4087 decoupled enable_dialout from sip_caller_phone, so the workaround of passing a dummy sip_caller_phone to enable dial-out is no longer needed.
markbackman
reviewed
Mar 27, 2026
markbackman
approved these changes
Mar 28, 2026
Update the commented send_dtmf example in both dial-in and dial-out bots to use the correct parameter name `digitDurationMs` instead of `duration`. This reflects the expected payload key for the transport.send_dtmf API and keeps examples consistent across daily-twilio-sip-dial-in and daily-twilio-sip-dial-out implementations.
Contributor
|
@vr000m feel free to merge once this is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_dialin_ready,on_dialin_connected,on_dialin_stopped,on_dialin_warning,on_dialin_error) to all dial-in and transfer botson_dialout_connected,on_dialout_stopped,on_dialout_warning) to PSTN dial-out and cold-transfer botson_dialout_warningto warm-transfer boton_dtmf_eventhandler to all PSTN bots (Twilio bots already had it)on_dialin_readysignature: usesip_endpointparam to match pipecat APITofield loggingNameErrorin cold-transfer bot whererequestwas undefinedsip_caller_phoneworkaround in dial-out bots (fixed in pipecat 0.0.107 via enable_dialout should not depend on sip_caller_phone being set pipecat#4087)Test plan