Skip to content

docs: roll back v8.5.6 Top SQL note and refresh v8.5 screenshots#22919

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
yibin87:rollback-v8.5.6-topsql-v8.5-screenshots
May 21, 2026
Merged

docs: roll back v8.5.6 Top SQL note and refresh v8.5 screenshots#22919
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
yibin87:rollback-v8.5.6-topsql-v8.5-screenshots

Conversation

@yibin87
Copy link
Copy Markdown
Contributor

@yibin87 yibin87 commented May 21, 2026

What is changed, added or deleted? (Required)

  • Roll back the v8.5.6 release note entry about Top SQL collecting TiKV Network IO / Logical IO metrics.
  • Refresh the v8.5 Top SQL screenshots under media/dashboard/.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Translated from: pingcap/docs-cn#21657

  • Other reference link(s):
    • releases/release-8.5.6.md
    • media/dashboard/v8.5-top-sql-*.png

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Signed-off-by: yibin87 <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes documentation entries related to the collection of TiKV network traffic and logical I/O metrics for Top SQL from the v8.5.6 release notes. Specifically, it deletes the feature description, the associated TiKV configuration parameter (resource-metering.enable-network-io-collection), and the corresponding improvement bullet point. I have no feedback to provide as there were no review comments to evaluate.

@yibin87 yibin87 requested a review from qiancai May 21, 2026 09:15
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 21, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 21, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-05-21 09:17:39.829146013 +0000 UTC m=+28590.470002816: ☑️ agreed by qiancai.

@qiancai qiancai added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels May 21, 2026
@qiancai
Copy link
Copy Markdown
Collaborator

qiancai commented May 21, 2026

/approve

@qiancai qiancai added the lgtm label May 21, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented May 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label May 21, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 131344c into pingcap:master May 21, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants