Better user interface to edit reverse DNS servers (dns.revServers)#3769
Better user interface to edit reverse DNS servers (dns.revServers)#3769rdwebdesign wants to merge 4 commits into
Conversation
rdwebdesign
force-pushed
the
tweak/multi_revServers2
branch
2 times, most recently
from
ec5ded4 to
927f408
Compare
- add functions and buttons to add, modify, undo changes and delete lines - generate the table using data already on the textarea - add functions to read textarea contents and parse then into an array - add functions to update the textarea contents from the table - hide the textarea. Only the table will be visible - make sure the table is not shown when the option was set by ENV VARS - move some help paragraphs to the table legend - remove usused original help text for the textarea - use fixed size for all action buttons - don't use "icheck" styling on the checkboxes in the table Signed-off-by: RD WebDesign <[email protected]>
rdwebdesign
force-pushed
the
tweak/multi_revServers2
branch
3 times, most recently
from
6233bee to
13b1af4
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rdwebdesign
force-pushed
the
tweak/multi_revServers2
branch
2 times, most recently
from
b55efd8 to
7574a91
Compare
There was a problem hiding this comment.
Saving gives an error about waitME
I think the re-filled example should not be ticked enabled by default if there is already an entry.
If you input a wrong network range and click add, an error 400 bad request will be shown in the console. Then the whole input areas are cleaned. I think it would be nicer if the wrong values would be preserved so users don't need to input everything but can just fix the issue.
Additionally, the wrong input will still be present in the payload, so FTL will reject it
Yeah... I think I messed up the waitME. I will take a look.
We can change that.
This is expected at the current PR state. |
|
I will mark as draft until I have the time to add validation and fix some issues. Please, feel free to keep testing the code even before I finish the PR. |
Maybe we can enable it automatically once users start to add real input in the fields? |
Signed-off-by: RD WebDesign <[email protected]>
Previously, the same function was used to initialize the table and update the table rows, when lines were added, edited or deleted. Now, one function initializes the table and another function saves the changes, shows a message and updates the table to reflect the changes. The values are "saved and applied" immediately using an AJAX call. The waitMe overlay is also shown, but the page is NOT reloaded. Signed-off-by: RD WebDesign <[email protected]>
Signed-off-by: RD WebDesign <[email protected]>
rdwebdesign
force-pushed
the
tweak/multi_revServers2
branch
from
7574a91 to
ccbc24b
Compare
Fixed. It was a previous bug: you can't call This function was created to be called directly on the class (like I used the |
|
Confirm waitMe error is gone. |
|
Thanks for testing. It would be better if we first merge PR3766. I want to use some of the validation functions already added there. |
3 participants
What does this PR aim to accomplish?
Replace the current single <textarea> with a table.
Each reverse server will be in a separate row and each field will be in a separate table cell.
A small legend will improve usability (maybe we will need to change the help text).
This is an update of #2943
How does this PR accomplish the above?
Using datatables plugin and the FTL API to save dns.revServers entries immediately.
This is still a work in progress.
TODO: