Fix lint configuration and apply fixes#7304
Open
niklas-e wants to merge 2 commits into
Open
Conversation
- Previous upgrade from v8 -> v10 caused linter to break because of unsupported configuration files
niklas-e
commented
May 16, 2026
Comment on lines
+132
to
+133
| 'no-useless-assignment': 'off', | ||
| 'no-constant-binary-expression': 'off' |
Author
There was a problem hiding this comment.
These two are new recommended rules from v9/v10, and caused quite a few errors. Not sure if these are desired so I disabled them.
Rule Count
no-useless-assignment 114
no-constant-binary-expression 4
Total 118
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linting was broken after recent eslint version upgrade from v8 to v10. See attached issue for more details.
Describe the changes below:
.eslintrc.jsonand.eslintignoretoeslint.config.mjsnpm run lintfixand fixed few remaining ones manuallyFixes #7303