Skip to content

T16522 transaction manager#16900

Merged
niden merged 3 commits intophalcon:5.0.xfrom
niden-code:T16522-transaction-manager
Apr 22, 2026
Merged

T16522 transaction manager#16900
niden merged 3 commits intophalcon:5.0.xfrom
niden-code:T16522-transaction-manager

Conversation

@niden
Copy link
Copy Markdown
Member

@niden niden commented Apr 22, 2026

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Model\Transaction\Manager::commit() to correctly call the garbage collection when a transaction is committed.

@niden niden requested a review from Jeckerson April 22, 2026 02:39
@niden niden self-assigned this Apr 22, 2026
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Apr 22, 2026
@niden niden changed the base branch from master to 5.0.x April 22, 2026 02:39
@niden niden merged commit 9ae42f5 into phalcon:5.0.x Apr 22, 2026
61 checks passed
@niden niden deleted the T16522-transaction-manager branch April 22, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants