Merged
Conversation
Jeckerson
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Replaces the deprecated
Phalcon\Tag\Selectusage inForms\Element\Select::render()with theTagFactory-basedHtml\Helper\Input\Selecthelper.Changes:
SelectDataInterfacewith two concrete implementations -ArrayData(wraps a plain PHP array) andResultsetData(wraps aResultsetInterfacewith a two-column using map) - keeping ORM concerns out of the HTML helper.Html\Helper\Input\Select::fromData()which iterates the data provider and delegates to existingadd()/optGroup()methods, with full optgroup support for nested arrays.Forms\Element\Select::render()to use the new helper, preserving all existing behavior: selected value,useEmpty/emptyValue/emptyText, using for resultsets,id/nameattribute handling, and bracket-name detection.usingParameterRequired,tagFactoryNotFound).AbstractElement::getLocalTagFactory()that constructed a freshTagFactoryfrom scratch; an explicit exception is now thrown when neithersetTagFactory()nor the parent Form provides one, with a null guard for environments where no DI container is registered.