This repository was archived by the owner on Jun 2, 2023. It is now read-only.
Draft: Update three.js to latest version#383
Open
bartenra wants to merge 42 commits intopchen66:masterfrom
Open
Draft: Update three.js to latest version#383bartenra wants to merge 42 commits intopchen66:masterfrom
bartenra wants to merge 42 commits intopchen66:masterfrom
Conversation
This reverts commit 5ffdf05.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly I replaced the ES5 style classes to ES6 classes. Seems to work OK, but some of the tests don't pass.
THREE.ShaderLib[ 'cube' ]['uniforms']['tCube'], which doesn't exist anymore._browserENV.jsprobably needs to be updated.