Confirm slide_model_path is used for slide-level model aggregation#102
Closed
Copilot wants to merge 1 commit intofeature/core-updatesfrom
Closed
Confirm slide_model_path is used for slide-level model aggregation#102Copilot wants to merge 1 commit intofeature/core-updatesfrom
Copilot wants to merge 1 commit intofeature/core-updatesfrom
Conversation
4 tasks
Copilot
AI
changed the title
[WIP] Update slide model path for slide-level model aggregation
Confirm slide_model_path is used for slide-level model aggregation
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review feedback indicated that
slide_model_pathshould be used for slide-level model aggregation. The variable was computed but not passed to downstream functions in the original commit.Changes
slide_model_pathnow flows from_main_single→process_slide_tessellation_and_filtering→save_features→aggregate_slide_featuresslide_model_pathflows from_main_batch→aggregate_slide_features_batchThe path is resolved from
cfg.slide_model_typeandcfg.model_dir, with fallback to HuggingFace paths when local models are unavailable.This was already fixed in commit c55fe74. This PR confirms the implementation is correct.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.