Run import process inside a SQL transaction#45
Open
ittner wants to merge 1 commit intopajowu:masterfrom
Open
Conversation
Start a SQL transaction before importing the back and commit it at the end of the process. This has no much effect when using in-memory databases, but makes everything *really* faster when not, as we don't need to persist every individual statement independently.
Owner
|
This looks great. I wanted to do that initially but couldn't figure it out properly. I will test this in the next days and hope we can merge that. If this works reliably we can get rid of the in memory db option alltogether 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start a SQL transaction before importing the back and commit it at the
end of the process. This has no much effect when using in-memory
databases, but makes everything really faster when not, as we don't
need to persist every individual statement independently.