ci(homebrew): fix Ruby interpolation in formula test block#1339
Merged
Conversation
The published formula renders the test as `system "{bin}/noir", "-v"`,
a literal path that breaks `brew test` / `brew audit`. Use `#{bin}` so
Homebrew interpolates the formula's bin path.
Same fix as hahwul/hwaro#518.
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
github-actions
Bot
added
🦺 github-action
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testblock readssystem "{bin}/noir", "-v"— a literal path, which breaksbrew testandbrew audit.#{bin}so Homebrew interpolates the formula's bin path.Formula/noir.rbcorrectly.Same fix as hahwul/hwaro#518 — caught while sweeping siblings for the same pattern.
Test plan
system "#{bin}/noir", "-v"andbrew test noirsucceeds