client: report manifest list digest for multi-arch images#250
Open
fitzthum wants to merge 1 commit intooras-project:mainfrom
Open
client: report manifest list digest for multi-arch images#250fitzthum wants to merge 1 commit intooras-project:mainfrom
fitzthum wants to merge 1 commit intooras-project:mainfrom
Conversation
fitzthum
requested review from
bacongobbler,
flavio and
thomastaylor312
as code owners
rajatchopra
approved these changes
Mar 24, 2026
src/client.rs
Outdated
| digest, | ||
| String::from_utf8(config.data.into()).map_err(|e| { | ||
| OciDistributionError::GenericError(Some(format!( | ||
| "Cannot not UTF8 compliant: {e}" |
There was a problem hiding this comment.
At some point lets fix the English.
Author
There was a problem hiding this comment.
This was in main, but I'll fix it up.
fitzthum
force-pushed
the
manifest-list
branch
2 times, most recently
from
129dd47 to
8fe143c
Compare
flavio
requested changes
Mar 31, 2026
Contributor
flavio
left a comment
flavio
left a comment
There was a problem hiding this comment.
Overall LGTM, can you:
- rebase against
main - address the GHA failures
Thanks!
When pulling a multi-arch image, this crate automatically resolves the manifest list to the appropriate arch manifest. When doing so, also keep track of the digest of the manifest list and report it to the caller. This helps callers validate signatures of multi-arch images. Since we ensure that the digests in the manifest list match any manifest that we pull from the manifest list, it is ok to sign just the top-level manifest, although some tools will sign recursively. Signed-off-by: Tobin Feldman-Fitzthum <[email protected]>
Author
|
@flavio I pushed a new version with the fixes. Can you spin the CI again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #247
When pulling a multi-arch image, this crate automatically resolves the manifest list to the appropriate arch manifest. This is at odds with some multi-arch signing schemes where the manifest list is signed.
To account for these scenarios, introduce a new method that that reports the manifest list digest (or None if not multi-arch).
cc @rajatchopra