Fix nodiscard warning in variant annotator test#822
Merged
lukhnos merged 1 commit intoopenvanilla:masterfrom Apr 27, 2026
Merged
Fix nodiscard warning in variant annotator test#822lukhnos merged 1 commit intoopenvanilla:masterfrom
lukhnos merged 1 commit intoopenvanilla:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates a unit test in VariantAnnotatorTest.cpp by casting the result of the annotate function to void within an EXPECT_DEATH macro. This change is likely intended to suppress compiler warnings related to unused return values. I have no feedback to provide as there are no review comments.
lukhnos
added a commit
to lukhnos/fcitx5-mcbopomofo
that referenced
this pull request
Apr 29, 2026
This includes changes from: - openvanilla/McBopomofo#499 - openvanilla/McBopomofo#794 - openvanilla/McBopomofo#822 Also did a clang-format pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
VariantAnnotatorTestdeath test to explicitly discard theannotate()return value withstatic_cast<void>. The test only verifies the assertion failure for mismatched argument counts, so the returnedVariantAnnotator::CombinedResultis intentionally unused. This keeps the test behavior unchanged while removing the compiler warning for the[[nodiscard]]return value.PS. the formatting differs from the surrounding context because it is produced by clang-format.
Warning