Fix the key to cancel the punctuation list.#820
Merged
zonble merged 2 commits intoopenvanilla:masterfrom Apr 20, 2026
Merged
Conversation
zonble
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the _handleCandidateState method in KeyHandler.mm to transition to InputStateEmptyIgnoringPreviousState when the grid becomes empty after a deletion. The review feedback suggests calling [self clear] before this transition to ensure the internal state, such as the walk result, is properly reset to avoid using stale data in subsequent inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user press ESC key while showing the punctuation list, it is expected that the inserted space should disappear. Currently the space would be inserted, and the PR fixes the issue.