You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Essentially deprecate playCount for totalPlayCount and userPlayCount. If the servers don't use the same value for playCount might as well work towards removing it with 2 new items
Note that there are scenarios where privacy is important: we don't want a user to be able to deduce anything about other users, such as listening habits.
Therefore, I wouldn't expect every OS server to necessarily implement this field, or if it does, it should be configurable
For a reader not having prior knowledge of these discussions, it's not at all obvious that fields totalCount and userCount have anything to do with the times the song has been played. So maybe they should be totalPlayCount and userPlayCount, even though these require a bit more typing?
Note that there are scenarios where privacy is important: we don't want a user to be able to deduce anything about other users, such as listening habits. Therefore, I wouldn't expect every OS server to necessarily implement this field, or if it does, it should be configurable
I would say that it's up to the server though to handle privacy but a good point. a count doesn't give you much information but it does give you information.
For a reader not having prior knowledge of these discussions, it's not at all obvious that fields totalCount and userCount have anything to do with the times the song has been played. So maybe they should be totalPlayCount and userPlayCount, even though these require a bit more typing?
lachlan-00
changed the title
separate playCount into totalCount and userCount
separate playCount into totalPlayCount and userPlayCount
May 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
discussed here
#96 (reply in thread)
Essentially deprecate playCount for totalPlayCount and userPlayCount. If the servers don't use the same value for playCount might as well work towards removing it with 2 new items