preset search - match when preset text is in term#12159
Open
matkoniecz wants to merge 1 commit intoopenstreetmap:developfrom
Open
preset search - match when preset text is in term#12159matkoniecz wants to merge 1 commit intoopenstreetmap:developfrom
matkoniecz wants to merge 1 commit intoopenstreetmap:developfrom
Conversation
currently only when search terms are within preset text or text is close then matches are found as result for example "private swimming pool" was not matching "swimming pool preset" fixes openstreetmap#9105
Contributor
Author
|
note: it may end adding some extra irrelevant or bizarre matches, but putting them at the end of list seems better than failing to match anything |
Contributor
Author
|
I also though about splitting search term and doing word-by-word search, like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently only when search terms are within preset text or text is close then matches are found
as result for example "private swimming pool" was not matching "swimming pool preset"
fixes #9105
Though it looks like sorting may be needed?