fix: Enforce minimum range boundaries for security compliance (fixes #746)#753
Open
ymh1874 wants to merge 1 commit into
Open
fix: Enforce minimum range boundaries for security compliance (fixes #746)#753ymh1874 wants to merge 1 commit into
ymh1874 wants to merge 1 commit into
Conversation
ymh1874
changed the title
gtema
force-pushed
the
fix/746-password-expires-range
branch
from
cea2bcd to
309938c
Compare
ymh1874
force-pushed
the
fix/746-password-expires-range
branch
from
309938c to
1c06c23
Compare
This patch introduces runtime configuration validation rules ensuring that specific security compliance settings (like 'password_expires_days', 'disable_user_account_days_inactive', etc.) are explicitly greater than zero. ConfigManager now forcibly invokes validation on startup and file reloads. Signed-off-by: Yousef Hussein <ymh1874@gmail.com>
ymh1874
force-pushed
the
fix/746-password-expires-range
branch
from
1c06c23 to
774a1cd
Compare
gtema
requested changes
Jun 5, 2026
Collaborator
gtema
left a comment
gtema
left a comment
There was a problem hiding this comment.
Looks good.
Would you mind adding a unittest (on the lib level and not under the security_compliance section) that explicitly tries to parse a config that would fail the validation ensuring the error is actually thrown. This way we can be sure that we prevent for accidental removing of the validation. I would be also interested to just to know whether the error message that the user will see will contain explanation of what is wrong or whether it is just a "failed validation" message with no further details. The scope is not to test validation of every single field, but to ensure the error message contain information useful to the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces runtime configuration validation rules ensuring that specific security compliance settings (like 'password_expires_days', 'disable_user_account_days_inactive', etc.) mirroring openstack/keystone python implementation.
The config crate has been updated to use the validator crate, and the ConfigManager now invokes validation on startup and file reloads.
Closes #746