feat: agent setup for ag-ui compatible ml agents#165
Draft
SuZhou-Joe wants to merge 1 commit intoopensearch-project:mainfrom
Draft
feat: agent setup for ag-ui compatible ml agents#165SuZhou-Joe wants to merge 1 commit intoopensearch-project:mainfrom
SuZhou-Joe wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
requested review from
FriedhelmWS,
Hailong-am,
raintygao,
wanglam and
yubonluo
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 65.16% 65.16%
=======================================
Files 56 56
Lines 1797 1797
Branches 429 418 -11
=======================================
Hits 1171 1171
Misses 623 623
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wanglam
reviewed
Oct 24, 2025
| const completeLines = lines.slice(0, -1); | ||
|
|
||
| for (const line of completeLines) { | ||
| if (line.startsWith('data: ')) { |
Collaborator
There was a problem hiding this comment.
Nit: can we store this as a constant and reuse it in the line.slice below?
| try { | ||
| while (true) { | ||
| const { done, value } = await reader.read(); | ||
| if (done) { |
Collaborator
There was a problem hiding this comment.
Do we need to check if this.sseBuffer is empty here? We may need to parse the data if it's starts with data:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a OSDAGUIAgent to connect to a AG-UI protocol stream response.
Trigger example: SuZhou-Joe#1
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.