Merged
Conversation
Since OpenJDK 21.0.10 /etc/timezone is no longer used to detect the default JVM time zone (JDK-8345213). * Update /etc/localtime symlink based on TZ environment variable * Install missing tzdata package in Alpine image * Update documentation Fixes openhab#485 Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Wouter Born <[email protected]>
wborn
force-pushed
the
fix-time-zone-issues
branch
from
11b384c to
186949b
Compare
Signed-off-by: Wouter Born <[email protected]>
wborn
force-pushed
the
fix-time-zone-issues
branch
from
0edb6da to
d8dc22c
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes timezone detection issues that arose from changes in OpenJDK 21.0.10, which no longer uses /etc/timezone to detect the default JVM timezone. The fix implements a more robust approach using the TZ environment variable and dynamic symlink creation at container startup.
Changes:
- Added
TZenvironment variable (default:Etc/UTC) to both Alpine and Debian Dockerfiles - Updated entrypoint scripts to create
/etc/localtimesymlink based onTZat runtime - Installed
tzdatapackage in Alpine image and configured default timezone symlink during build - Updated documentation to replace volume mount approach with
TZenvironment variable usage
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| debian/Dockerfile | Added TZ environment variable with default value "Etc/UTC" |
| debian/entrypoint | Added timezone configuration by creating symlink from TZ to /etc/localtime |
| alpine/Dockerfile | Added TZ environment variable and tzdata package installation, with build-time symlink creation |
| alpine/entrypoint | Added timezone configuration by creating symlink from TZ to /etc/localtime |
| README.md | Removed volume mount examples for /etc/localtime and /etc/timezone, replaced with TZ environment variable usage across all examples, added new timezone configuration documentation section, and corrected Ansible YAML syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Wouter Born <[email protected]>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since OpenJDK 21.0.10 /etc/timezone is no longer used to detect the default JVM time zone (JDK-8345213).
Fixes #485