Add full and minimal docker profiles#3107
Open
kerneljack wants to merge 7 commits intoopen-telemetry:mainfrom
Open
Add full and minimal docker profiles#3107kerneljack wants to merge 7 commits intoopen-telemetry:mainfrom
kerneljack wants to merge 7 commits intoopen-telemetry:mainfrom
Conversation
github-actions
bot
added
the
helm-update-required
Contributor
|
Thanks for the contribution! Could we update the PR title to describe what this PR is doing? ATM I don't know what "Light Branch Fixes" means. Thanks! |
Contributor
Author
|
@osullivandonal thanks for checking the PR. I have updated the title now. The linked Github issue has more context, but I'll add it again here: |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This adds on to the work done by @julianocosta89 in #2396 to add docker profiles to the Demo app.
I have tested the functionality of the Demo app itself and the Grafana Demo dashboard using both the full and minimal profiles.
You can use
make startfor the full profile andmake start-minimalfor the minimal profile.I have attempted to fix the tests and most of them work except for one.
Merge Requirements
For new features contributions, please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.