Convernt question mark in instance variables#7
Open
m-jarmula wants to merge 1 commit intoonthebeach:masterfrom
Open
Convernt question mark in instance variables#7m-jarmula wants to merge 1 commit intoonthebeach:masterfrom
m-jarmula wants to merge 1 commit intoonthebeach:masterfrom
Conversation
m-jarmula
force-pushed
the
bugfix/protect-instance-variable-from-question-marks
branch
2 times, most recently
from
f24964b to
b9ad34f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: We create instance variable based on keys passed in constructor. Ruby doesn't allow to have question mark in the instance variable name.
Solution:
This PR will check if the last character of the
ivar_nameis?if so it will replace it with_question_mark.Current workaround is to make a regular field and set a key for this field, but this approach breaks code convention, besides that the gems by default returns hash structure with question mark.
Warnings
We use this feature as a concern to gain some memory performance